Global error handler cleanup - Metrics View

[lalitb]

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

• CONTRIBUTING guidelines followed
• Unit tests added/updated (if applicable)
• Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
• Changes in public API reviewed (if applicable)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.6%. Comparing base (1a73d52) to head (cd57696).
Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #2249   +/-   ##
=====================================
  Coverage   79.5%   79.6%           
=====================================
  Files        121     121           
  Lines      20950   20938   -12     
=====================================
- Hits       16672   16668    -4     
+ Misses      4278    4270    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cijothomas]

for a method that returns Result, I don't think there is any need of internal logging. If we really want to do some log, then it should be Debug level.

[lalitb]

The actual error is getting lost in all these cases, as we just return success with empty view.

[cijothomas]

if we always return success, then that looks like a flaw. Since it is not introduced in this PR, lets remove the error logging from here, and put a todo (optional). We need to rework the View and can fix these then.

[lalitb]

Added TODO, and removed logging.

[cijothomas]

See: https://github.com/open-telemetry/opentelemetry-rust/pull/2249/files#r1817683313