-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global error handler cleanup - Metrics Pipeline #2244
Global error handler cleanup - Metrics Pipeline #2244
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2244 +/- ##
=====================================
Coverage 79.5% 79.5%
=====================================
Files 121 121
Lines 20938 20938
=====================================
Hits 16656 16656
Misses 4282 4282 ☔ View full report in Codecov by Sentry. |
// If an existing instrument with the same name but different attributes is found, | ||
// log a warning with details about the conflicting metric stream definitions. | ||
otel_warn!( | ||
name: "Instrument.DuplicateMetricStreamDefinitions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what is the action end users are expected to do when they see this.. If this is only for sdk maintainers to debug, then lets use debug level only. If keeping at Warn, then it should be actionable/descriptive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes