-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global error handler cleanup - ManualReader #2236
Global error handler cleanup - ManualReader #2236
Conversation
)) | ||
otel_debug!( | ||
name: "ManualReader.DuplicateRegistration", | ||
message = "The pipeline is already registered to the Reader. Registering pipeline multiple times is not allowed."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Utkarsh's comment:
1.
name: "ManualReader.RegisterPipeline.DuplicateRegistration",
name: "ManualReader.DuplicateRegistration",
2.
replace error
with `message
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2236 +/- ##
=====================================
Coverage 79.5% 79.5%
=====================================
Files 121 121
Lines 21113 21113
=====================================
Hits 16805 16805
Misses 4308 4308 ☔ View full report in Codecov by Sentry. |
Merging this. ARM64 CI tests are not starting for different reason, Will look into it separately -
|
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes