Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTLP Exporter] Mark a few APIs private #2229

Closed
wants to merge 1 commit into from
Closed

[OTLP Exporter] Mark a few APIs private #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opentelemetry-otlp/src/logs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@

impl LogExporterBuilder {
/// Build a OTLP log exporter using the given configuration.
pub fn build_log_exporter(self) -> Result<LogExporter, LogError> {
fn build_log_exporter(self) -> Result<LogExporter, LogError> {

Check warning on line 61 in opentelemetry-otlp/src/logs.rs

View check run for this annotation

Codecov / codecov/patch

opentelemetry-otlp/src/logs.rs#L61 

Added line #L61 was not covered by tests
match self {
#[cfg(feature = "grpc-tonic")]
LogExporterBuilder::Tonic(builder) => builder.build_log_exporter(),
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-otlp/src/metric.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@

impl MetricsExporterBuilder {
/// Build a OTLP metrics exporter with given configuration.
pub fn build_metrics_exporter(self, temporality: Temporality) -> Result<MetricsExporter> {
fn build_metrics_exporter(self, temporality: Temporality) -> Result<MetricsExporter> {

Check warning on line 77 in opentelemetry-otlp/src/metric.rs

View check run for this annotation

Codecov / codecov/patch

opentelemetry-otlp/src/metric.rs#L77 

Added line #L77 was not covered by tests
match self {
#[cfg(feature = "grpc-tonic")]
MetricsExporterBuilder::Tonic(builder) => builder.build_metrics_exporter(temporality),
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-otlp/src/span.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ pub enum SpanExporterBuilder {

impl SpanExporterBuilder {
/// Build a OTLP span exporter using the given tonic configuration and exporter configuration.
pub fn build_span_exporter(self) -> Result<SpanExporter, TraceError> {
fn build_span_exporter(self) -> Result<SpanExporter, TraceError> {
match self {
#[cfg(feature = "grpc-tonic")]
SpanExporterBuilder::Tonic(builder) => builder.build_span_exporter(),
Expand Down
Loading