Provide default implementation for event_enabled trait in LogProcessor #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
approved these changes
Aug 14, 2024
cijothomas
added a commit
to cijothomas/opentelemetry-rust
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide default implementation for
event_enabledtrait in LogProcessor, so only those implementations that care about this feature need to implement and override the method. Less thing for LogProcessor author to worry about.I am also thinking we should do default implementation for flush, shutdown as well, and only those processor that need to care about them should override it. For example, If one were writing a
EnrichProcessor, it has no interest in flush or shutdown. If this direction is accepted, I can send similar change for Flush, Shutdown as well.