Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics aggregation bug for Sum and Precomputed Sum to avoid duplicate export #2018

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Aug 13, 2024

We missed adding a few HashSet checks to avoid duplicate exports in #1989. The affected aggregations are:

  • Sum (Cumulative)
  • PrecomputedSum (Delta)
  • PrecomputedSum (Cumulative)

Changes

  • Fix the affected aggregations
  • Update the existing related tests to test for both Delta and Cumulative temporality

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team August 13, 2024 19:35
@utpilla utpilla changed the title Fix metrics aggregation for Sum and Precomputed Sum to avoid duplicate export Fix metrics aggregation bug for Sum and Precomputed Sum to avoid duplicate export Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.1%. Comparing base (07b918d) to head (a3cfaaf).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2018   +/-   ##
=====================================
  Coverage   76.1%   76.1%           
=====================================
  Files        122     122           
  Lines      20684   20700   +16     
=====================================
+ Hits       15750   15766   +16     
  Misses      4934    4934           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more gaps in testing identified.
As mentioned in community call, I'll do a full check on the overall coverage, and reorganize the tests so it is easy to tell what is covered and what is not!

Thanks!

@cijothomas cijothomas merged commit f2e9df2 into open-telemetry:main Aug 13, 2024
25 checks passed
cijothomas added a commit to cijothomas/opentelemetry-rust that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants