Fix config for otlp example and integration test #2003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry#1998 With updates to the otel collector 0.104+, the collector now binds to localhost by default. The config now needs to explicitly allow access from outside the docker container.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
=====================================
Coverage 79.0% 79.0%
=====================================
Files 121 121
Lines 20856 20856
=====================================
Hits 16482 16482
Misses 4374 4374 ☔ View full report in Codecov by Sentry. |
|
@krlohnes Thanks for the PR. Changes look good, but you need to sign the CLA before it can be merged. |
|
@lalitb I'm working through the CLA process with the company I work for. |
|
@krlohnes Any progress with getting CLA process solved? |
|
@cijothomas I unfortunately haven't made any progress on that front. I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1998
Changes
With updates to the otel collector 0.104+, the collector now binds to localhost by default. The config now needs to explicitly allow access from outside the docker container.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes