Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appender-Tracing benchmark to pass message as attribute - 10% faster #2001

Merged

Conversation

cijothomas
Copy link
Member

Tracing appender benchmarks were using textual message, which is less performant that putting them as structured key-value pair.
https://docs.rs/tracing/latest/tracing/event/struct.Event.html mentions majority should be using fields, but does not strongly recommend against textual message. We (OTel) should prefer showing examples with fields only and no messages. I put a TODO in the appender to special case "message" to populate body.

Simply removing the textual message and storing the same content in a named field (in benchmark), shows 10% perf gain, which shows how much worse is not using fields. For fields, we current allocate+copy the string, but that is something to be revisited and fixed later, which should further speed this up.

@cijothomas cijothomas requested a review from a team August 8, 2024 03:02
@cijothomas cijothomas changed the title Appender-Tracing benchmark to pass message as attribute Appender-Tracing benchmark to pass message as attribute 10% faster Aug 8, 2024
@cijothomas cijothomas changed the title Appender-Tracing benchmark to pass message as attribute 10% faster Appender-Tracing benchmark to pass message as attribute - 10% faster Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8%. Comparing base (2bba6b0) to head (b9bb850).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2001   +/-   ##
=====================================
  Coverage   74.8%   74.8%           
=====================================
  Files        122     122           
  Lines      20678   20686    +8     
=====================================
+ Hits       15474   15482    +8     
  Misses      5204    5204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb merged commit 60f3324 into open-telemetry:main Aug 9, 2024
25 checks passed
@cijothomas cijothomas deleted the cijothomas/fix-appender-bench branch August 9, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants