Appender-Tracing benchmark to pass message as attribute - 10% faster #2001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing appender benchmarks were using textual message, which is less performant that putting them as structured key-value pair.
https://docs.rs/tracing/latest/tracing/event/struct.Event.html mentions majority should be using fields, but does not strongly recommend against textual message. We (OTel) should prefer showing examples with fields only and no messages. I put a TODO in the appender to special case "message" to populate body.
Simply removing the textual message and storing the same content in a named field (in benchmark), shows 10% perf gain, which shows how much worse is not using fields. For fields, we current allocate+copy the string, but that is something to be revisited and fixed later, which should further speed this up.