Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logs-appender-tracing] Use method from tracing-core instead of creating our own #1999

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Aug 7, 2024

Follow-up to #1997

Changes

  • Use Level.as_str() method from the tracing-core create instead of creating our own mapping method

@utpilla utpilla requested a review from a team August 7, 2024 21:36
@utpilla utpilla marked this pull request as draft August 7, 2024 21:37
@utpilla utpilla marked this pull request as ready for review August 7, 2024 21:46
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit fe10ab1 into open-telemetry:main Aug 7, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants