Fix integration test and address feedback

open-telemetry · Dec 18, 2024 · f169f06 · f169f06
1 parent 1f31465
commit f169f06
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/opentelemetry-otlp/tests/integration_test/tests/logs.rs b/opentelemetry-otlp/tests/integration_test/tests/logs.rs
@@ -28,7 +28,7 @@ fn init_logs() -> Result<sdklogs::LoggerProvider> {
     let exporter = exporter_builder.build()?;
 
     Ok(LoggerProvider::builder()
-        .with_batch_exporter(exporter, runtime::Tokio)
+        .with_batch_exporter(exporter)
         .with_resource(
             Resource::builder_empty()
                 .with_service_name("logs-integration-test")

diff --git a/opentelemetry-sdk/src/logs/log_processor.rs b/opentelemetry-sdk/src/logs/log_processor.rs
@@ -1198,9 +1198,6 @@ mod tests {
         let exporter = InMemoryLogExporterBuilder::default().build();
         let processor = BatchLogProcessor::new(Box::new(exporter.clone()), BatchConfig::default());
 
-        //
-        // deadloack happens in shutdown with tokio current_thread runtime
-        //
         processor.shutdown().unwrap();
     }