resource: remove vec allocations for attributes (#2429)

open-telemetry · Dec 14, 2024 · b8380eb · b8380eb
1 parent d2e179e
commit b8380eb
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 14 deletions.
diff --git a/opentelemetry-otlp/src/lib.rs b/opentelemetry-otlp/src/lib.rs
@@ -162,7 +162,7 @@
 //!                 .with_max_events_per_span(64)
 //!                 .with_max_attributes_per_span(16)
 //!                 .with_max_events_per_span(16)
-//!                 .with_resource(Resource::builder_empty().with_attributes(vec![KeyValue::new("service.name", "example")]).build()),
+//!                 .with_resource(Resource::builder_empty().with_attributes([KeyValue::new("service.name", "example")]).build()),
 //!         ).build();
 //!     global::set_tracer_provider(tracer_provider);
 //!     let tracer = global::tracer("tracer-name");
@@ -186,7 +186,7 @@
 //!
 //!    let provider = opentelemetry_sdk::metrics::SdkMeterProvider::builder()
 //!        .with_reader(reader)
-//!         .with_resource(Resource::builder_empty().with_attributes(vec![KeyValue::new("service.name", "example")]).build())
+//!         .with_resource(Resource::builder_empty().with_attributes([KeyValue::new("service.name", "example")]).build())
 //!         .build();
 //!     # }
 //!

diff --git a/opentelemetry-sdk/src/logs/log_emitter.rs b/opentelemetry-sdk/src/logs/log_emitter.rs
@@ -448,7 +448,7 @@ mod tests {
                 let user_provided_resource_config_provider = super::LoggerProvider::builder()
                     .with_resource(
                         Resource::builder()
-                            .with_attributes(vec![
+                            .with_attributes([
                                 KeyValue::new("my-custom-key", "my-custom-value"),
                                 KeyValue::new("my-custom-key2", "my-custom-value2"),
                             ])

diff --git a/opentelemetry-sdk/src/logs/log_processor.rs b/opentelemetry-sdk/src/logs/log_processor.rs
@@ -769,7 +769,7 @@ mod tests {
             .with_log_processor(processor)
             .with_resource(
                 Resource::builder_empty()
-                    .with_attributes(vec![
+                    .with_attributes([
                         KeyValue::new("k1", "v1"),
                         KeyValue::new("k2", "v3"),
                         KeyValue::new("k3", "v3"),
@@ -796,7 +796,7 @@ mod tests {
             .with_log_processor(processor)
             .with_resource(
                 Resource::builder_empty()
-                    .with_attributes(vec![
+                    .with_attributes([
                         KeyValue::new("k1", "v1"),
                         KeyValue::new("k2", "v3"),
                         KeyValue::new("k3", "v3"),

diff --git a/opentelemetry-sdk/src/logs/mod.rs b/opentelemetry-sdk/src/logs/mod.rs
@@ -28,7 +28,7 @@ mod tests {
     fn logging_sdk_test() {
         // Arrange
         let resource = Resource::builder_empty()
-            .with_attributes(vec![
+            .with_attributes([
                 KeyValue::new("k1", "v1"),
                 KeyValue::new("k2", "v2"),
                 KeyValue::new("k3", "v3"),

diff --git a/opentelemetry-sdk/src/metrics/meter_provider.rs b/opentelemetry-sdk/src/metrics/meter_provider.rs
@@ -394,7 +394,7 @@ mod tests {
                     .with_reader(reader4)
                     .with_resource(
                         Resource::builder()
-                            .with_attributes(vec![
+                            .with_attributes([
                                 KeyValue::new("my-custom-key", "my-custom-value"),
                                 KeyValue::new("my-custom-key2", "my-custom-value2"),
                             ])

diff --git a/opentelemetry-sdk/src/resource/env.rs b/opentelemetry-sdk/src/resource/env.rs
@@ -75,7 +75,7 @@ pub struct SdkProvidedResourceDetector;
 impl ResourceDetector for SdkProvidedResourceDetector {
     fn detect(&self) -> Resource {
         Resource::builder_empty()
-            .with_attributes(vec![KeyValue::new(
+            .with_attributes([KeyValue::new(
                 super::SERVICE_NAME,
                 env::var(OTEL_SERVICE_NAME)
                     .ok()
@@ -116,7 +116,7 @@ mod tests {
                 assert_eq!(
                     resource,
                     Resource::builder_empty()
-                        .with_attributes(vec![
+                        .with_attributes([
                             KeyValue::new("key", "value"),
                             KeyValue::new("k", "v"),
                             KeyValue::new("a", "x"),

diff --git a/opentelemetry-sdk/src/resource/mod.rs b/opentelemetry-sdk/src/resource/mod.rs
@@ -352,7 +352,7 @@ mod tests {
     #[test]
     fn merge_resource_key_value_pairs() {
         let resource_a = Resource::builder_empty()
-            .with_attributes(vec![
+            .with_attributes([
                 KeyValue::new("a", ""),
                 KeyValue::new("b", "b-value"),
                 KeyValue::new("d", "d-value"),
@@ -452,7 +452,7 @@ mod tests {
                 assert_eq!(
                     resource,
                     Resource::builder_empty()
-                        .with_attributes(vec![
+                        .with_attributes([
                             KeyValue::new("key", "value"),
                             KeyValue::new("k", "v"),
                             KeyValue::new("a", "x"),
@@ -519,7 +519,7 @@ mod tests {
                     .with_detector(Box::new(EnvResourceDetector::new()))
                     .with_service_name("testing_service")
                     .with_attribute(KeyValue::new("test1", "test_value"))
-                    .with_attributes(vec![
+                    .with_attributes([
                         KeyValue::new("test1", "test_value1"),
                         KeyValue::new("test2", "test_value2"),
                     ])
@@ -528,7 +528,7 @@ mod tests {
                 assert_eq!(
                     resource,
                     Resource::builder_empty()
-                        .with_attributes(vec![
+                        .with_attributes([
                             KeyValue::new("key", "value"),
                             KeyValue::new("test1", "test_value1"),
                             KeyValue::new("test2", "test_value2"),

diff --git a/opentelemetry-sdk/src/trace/provider.rs b/opentelemetry-sdk/src/trace/provider.rs
@@ -604,7 +604,7 @@ mod tests {
                 let user_provided_resource_config_provider = super::TracerProvider::builder()
                     .with_resource(
                         Resource::builder()
-                            .with_attributes(vec![
+                            .with_attributes([
                                 KeyValue::new("my-custom-key", "my-custom-value"),
                                 KeyValue::new("my-custom-key2", "my-custom-value2"),
                             ])