Skip to content

Commit

Permalink
Nit spelling fixes (#2443)
Browse files Browse the repository at this point in the history
  • Loading branch information
cijothomas authored Dec 18, 2024
1 parent b9a422b commit 9011f63
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 2 additions & 0 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@
"nocapture",
"Ochtman",
"opentelemetry",
"OTELCOL",
"OTLP",
"periodicreader",
"protoc",
"quantile",
"Redelmeier",
Expand Down
6 changes: 2 additions & 4 deletions opentelemetry-otlp/examples/basic-otlp-http/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ recommended approach when using OTLP exporters. While it can be modified to use
a `SimpleExporter`, this requires enabling feature flag `reqwest-blocking-client` and
making the `main()` a normal main and *not* `tokio::main`

// TODO: Metrics does not work with non tokio main when using `reqwest-blocking-client` today, fix that when switching
// TODO: Metrics does not work with non tokio main when using `reqwest-blocking-client` today, fix that when switching
// default to use own thread.
// TODO: Document `hyper` feature flag when using SimpleProcessor.

Expand Down Expand Up @@ -66,14 +66,12 @@ Run the app which exports logs, metrics and traces via OTLP to the collector
cargo run
```


By default the app will use a `reqwest` client to send. A hyper 0.14 client can be used with the `hyper` feature enabled

```shell
cargo run --no-default-features --features=hyper
```


## View results

You should be able to see something similar below with different time and ID in the same console that docker runs.
Expand Down Expand Up @@ -135,7 +133,7 @@ SpanEvent #0
-> Timestamp: 2024-05-14 02:15:56.824201397 +0000 UTC
-> DroppedAttributesCount: 0
-> Attributes::
-> bogons: Int(100)
-> some.key: Int(100)
{"kind": "exporter", "data_type": "traces", "name": "logging"}
...
```
Expand Down
4 changes: 2 additions & 2 deletions opentelemetry-otlp/examples/basic-otlp-http/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> {

// Create a new tracing::Fmt layer to print the logs to stdout. It has a
// default filter of `info` level and above, and `debug` and above for logs
// from OpenTelemtry crates. The filter levels can be customized as needed.
// from OpenTelemetry crates. The filter levels can be customized as needed.
let filter_fmt = EnvFilter::new("info").add_directive("opentelemetry=debug".parse().unwrap());
let fmt_layer = tracing_subscriber::fmt::layer()
.with_thread_names(true)
Expand Down Expand Up @@ -148,7 +148,7 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> {
let span = cx.span();
span.add_event(
"Nice operation!".to_string(),
vec![KeyValue::new("bogons", 100)],
vec![KeyValue::new("some.key", 100)],
);
span.set_attribute(KeyValue::new("another.key", "yes"));

Expand Down
4 changes: 2 additions & 2 deletions opentelemetry-otlp/examples/basic-otlp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ recommended approach when using OTLP exporters. While it can be modified to use
a `SimpleExporter`, this requires the main method to be a `tokio::main` function
since the `tonic` client requires a Tokio runtime. If you prefer not to use
`tokio::main`, then the `init_logs` and `init_traces` functions must be executed
within a Tokio runtime.
within a Tokio runtime.

This examples uses the default `PeriodicReader` for metrics, which uses own
thread for background processing/exporting. Since the `tonic` client requires a
Expand Down Expand Up @@ -154,7 +154,7 @@ SpanEvent #0
-> Timestamp: 2024-05-22 20:25:42.8770471 +0000 UTC
-> DroppedAttributesCount: 0
-> Attributes::
-> bogons: Int(100)
-> some.key: Int(100)
{"kind": "exporter", "data_type": "traces", "name": "logging"}
```

Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-otlp/examples/basic-otlp/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ async fn main() -> Result<(), Box<dyn Error + Send + Sync + 'static>> {

// Create a new tracing::Fmt layer to print the logs to stdout. It has a
// default filter of `info` level and above, and `debug` and above for logs
// from OpenTelemtry crates. The filter levels can be customized as needed.
// from OpenTelemetry crates. The filter levels can be customized as needed.
let filter_fmt = EnvFilter::new("info").add_directive("opentelemetry=debug".parse().unwrap());
let fmt_layer = tracing_subscriber::fmt::layer()
.with_thread_names(true)
Expand Down

0 comments on commit 9011f63

Please sign in to comment.