Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds on_ending callback to allow processors to mutate spans before End operation #1713

Merged
merged 11 commits into from
Oct 1, 2024
Merged

Adds on_ending callback to allow processors to mutate spans before End operation #1713

merged 11 commits into from
Oct 1, 2024

Commits on Sep 1, 2024

  1. feature: adds on_ending method as an optional callback for span proce… 

    …ssors

Signed-off-by: Gustavo Pantuza <[email protected]>
    @pantuza
    pantuza committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    90b2c85 View commit details
    Browse the repository at this point in the history

  2. feature: calls every span processor that has on_ending implemented ri… 

    …ght after setting the end timestamp

Signed-off-by: Gustavo Pantuza <[email protected]>
    @pantuza
    pantuza committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    93e6d9f View commit details
    Browse the repository at this point in the history

  3. test: adds tests for the new on_ending method from span processors 

    Signed-off-by: Gustavo Pantuza <[email protected]>
    @pantuza
    pantuza committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    0f1cf16 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:open-telemetry/opentelemetry-ruby i… 

    …nto span-processor-on-ending-interface
    @pantuza
    pantuza committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    e1c7cc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. docs: Informs the on_ending callback is an experimental features from… 

    … official spec

Signed-off-by: Gustavo Pantuza <[email protected]>
    @pantuza
    pantuza committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2c28b76 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Update sdk/lib/opentelemetry/sdk/trace/span_processor.rb 

    Co-authored-by: Kayla Reopelle <[email protected]>
    @pantuza @kaylareopelle
    pantuza and kaylareopelle authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9d9c944 View commit details
    Browse the repository at this point in the history

  2. Update sdk/lib/opentelemetry/sdk/trace/span_processor.rb 

    Co-authored-by: Kayla Reopelle <[email protected]>
    @pantuza @kaylareopelle
    pantuza and kaylareopelle authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    173e57a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:open-telemetry/opentelemetry-ruby i… 

    …nto span-processor-on-ending-interface
    @pantuza
    pantuza committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a2802af View commit details
    Browse the repository at this point in the history

  4. Merge branch 'span-processor-on-ending-interface' of github.com:pantu… 

    …za/opentelemetry-ruby into span-processor-on-ending-interface
    @pantuza
    pantuza committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fe7c455 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-ruby i… 

    …nto span-processor-on-ending-interface
    @pantuza
    pantuza committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c9bb0f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. refactor: switch method name from on_ending to on_finish to comply wi… 

    …th project name strategy

Signed-off-by: Gustavo Pantuza <[email protected]>
    @pantuza
    pantuza committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fc085c3 View commit details
    Browse the repository at this point in the history