Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable max backoff for GRPC exporter #4333

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

awoimbee
Copy link

Description

Fixes #4331

This makes it so _create_exp_backoff_generator is called with self._MAX_RETRY_TIMEOUT instead of a local var, like absolutely everywhere else, in the grpc exporter.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@awoimbee awoimbee requested a review from a team as a code owner November 28, 2024 15:39
@awoimbee
Copy link
Author

Bump. I don't think there is any potential downside to merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc OTLPSpanExporter max retry timeout is not configurable
1 participant