Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace assertEqualSpanInstrumentationInfo with assertEqualSpanInstrumentationScope #3037

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Replace assertEqualSpanInstrumentationInfo with assertEqualSpanInstrumentationScope #3037

merged 4 commits into from
Nov 22, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Nov 21, 2024 •
edited
Loading

Description

Fixes #3033

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run all existing unit tests.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tammy-baylis-swi tammy-baylis-swi changed the title Replace assertInstInfo with assertInstScope Replace assertEqualSpanInstrumentationInfo with assertEqualSpanInstrumentationScope Nov 21, 2024
@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review November 21, 2024 22:54
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner November 21, 2024 22:54
@xrmx xrmx merged commit 5c5fc73 into open-telemetry:main Nov 22, 2024
566 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the test-deprecation-warnings branch November 22, 2024 17:14
@tammy-baylis-swi tammy-baylis-swi mentioned this pull request Nov 22, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@xrmx xrmx xrmx approved these changes

Assignees

@federicobond federicobond

@shalevr shalevr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop TestBase DeprecationWarnings from instrumentor test span info checks
5 participants
@tammy-baylis-swi @xrmx @lzchen @federicobond @shalevr