DB-API instrument_connection accepts optional connect_module

[tammy-baylis-swi]

Description

DB-API instrument_connection accepts optional connect_module.

Should be merged before #2942

Fixes #3028

Relates to #2902

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[codefromthecrypt]

Thanks, I suppose testing here was thought about but considered too much code for what it is covering?

[aabmass]

Thanks, I suppose testing here was thought about but considered too much code for what it is covering?

@tammy-baylis-swi any thoughts on this? I can merge once resolved

[tammy-baylis-swi]

Thanks, I suppose testing here was thought about but considered too much code for what it is covering?

@tammy-baylis-swi any thoughts on this? I can merge once resolved

Yeah more tests! I added some in 916bf5e. Let me know if any changes/more needed.