Fix psycopg2 instrument issue #2795
Conversation
Signed-off-by: Qiu, David <[email protected]>
...pentelemetry-instrumentation-psycopg2/src/opentelemetry/instrumentation/psycopg2/__init__.py
Show resolved
Hide resolved
Signed-off-by: Qiu, David <[email protected]>
Signed-off-by: Qiu, David <[email protected]>
Signed-off-by: Qiu, David <[email protected]>
|
Thanks for your suggestion, I will add a test case for it. |
|
instrumentation/opentelemetry-instrumentation-psycopg2/tests/test_psycopg2_integration.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Qiu, David <[email protected]>
Signed-off-by: Qiu, David <[email protected]>
| connection._is_instrumented_by_opentelemetry = True | ||
| else: | ||
| def instrument_connection(self, connection, tracer_provider=None): | ||
| if isinstance(connection, ObjectProxy): |
There was a problem hiding this comment.
I'm still not sure this solves the original issue (we still don't know WHY the error is being generated when we are trying to access _is_instrumented_by_opentelemetry field but this current change is fine as a short-term solution. Please add a TODO or follow-up issue to investigate.
|
Please allow for maintainer edits so we can rebase for you. |
|
Hi @qiuge615 are you still working on this PR? |
Description
Currently there is issue with psycopg2, the instrumentation can not work as expected. Update the codes based on mysql and sqlite3 to resolve the issue. Will check the two properties _otel_orig_cursor_factory and _is_instrumented_by_opentelemetry in subsequent issue later.
Fix one issue in unit test, assign instrumented connection to cnx.
Fixes #2522
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested with below command to run unit test
tox -e py310-test-opentelemetry-instrumentation-psycopg2
Tested traces with local environment and the traces are displayed without error.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.