Update description of active requests counter for Django and aiohttp #2514
Conversation
|
|
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
| @@ -213,7 +213,7 @@ async def middleware(request, handler): | |||
| active_requests_counter = meter.create_up_down_counter( | |||
| name=MetricInstruments.HTTP_SERVER_ACTIVE_REQUESTS, | |||
| unit="requests", | |||
| description="measures the number of concurrent HTTP requests those are currently in flight", | |||
| description="measures the number of concurrent HTTP requests that are currently in-flight", | |||
There was a problem hiding this comment.
@lmolkova updated the semantic convention package in open-telemetry/opentelemetry-python#3586 to generate instrument creation factories we could use here
@lmolkova would you recommend updating here to use create_http_server_active_requests()?
There was a problem hiding this comment.
yep, that would be great! if you see any issues/opportunities to improve, lmk, happy to update helpers.
There was a problem hiding this comment.
@dkliban could you update the PR to use this function for instrument creation?
There was a problem hiding this comment.
i'll try to do that. i haven't seen it actually used anywhere yet.
There was a problem hiding this comment.
That's right, we are using the instrument creation factories now for the migration to the new semconv. At this point, we didn't include aiohttp-server in the list of instrumentation to migrate to the new semconv, but I think it's important since we can release the package now.
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
|
Closing this PR because the change was implemented here #2714 |
fixes: #2513