Added dynamodb instrumenter for aws v1_11 sdk

[akats7]

Resolves #12493

Added a dynamo instrumenter for the aws v1_11 sdk. The most important thing this provides is the db.system attribute which was previously missing and is required according to the sem conv for dynamo. Table name has also been added as an attribute, the instrumenter can continue to be enhanced to add additional 'recommended' attributed from the semantic conventions.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: akats7 / name: Alex Kats (70daf4e, 9857868, 647d433, 1b0a198, fceec97, fd2f694, 3c0acac, 61c014c, d2b7fed, 09e823a)

[steverao]

There are some CI failings, you can refer to related contribution docs to fix them:

[akats7]

The tests were recently rewritten so I need to update them

[akats7]

Hey @steverao @trask, all build issues have been resolved, thanks.

[trask]

it's a bit confusing to have both aws.dynamodb.table_names and aws.table.name at the same time, but I don't have a better idea (and aws.table.name requires experimental flag to get anyways)

[akats7]

Yep I had the same qualm but I don't want to introduce a breaking change and also wanted to align to the sem convs

[jaydeluca]

this is just an observation more than a request for a change - I understand that this attribute is a List<String> based on the spec, but it doesn't look like this code supports multiple table names, so it feels a little strange for it be defined that way

[akats7]

Yeah we can likely make an additional enhancement that creates a Request Accessor for the methods that are tied to table names for the batch functions, and then add that Request Accessor to the logic for setting the value. Right now getTable is tied to getTableName which will always return one.

[jaydeluca]

slight nitpick: perhaps the usage of these variables provides enough context, but it might be a little more intuitive if the names indicated that they reference the names of classes

Suggested change

	private static final String SEND_MESSAGE_REQUEST =
	"com.amazonaws.services.sqs.model.SendMessageRequest";
	private static final String DYNAMODBV2 = "com.amazonaws.services.dynamodbv2.model.";
	private static final String SEND_MESSAGE_REQUEST_CLASS =
	"com.amazonaws.services.sqs.model.SendMessageRequest";
	private static final String DYNAMODBV2_CLASS = "com.amazonaws.services.dynamodbv2.model.";

[laurit]

usually we add a comment about where this value was copied from like in

opentelemetry-java-instrumentation/instrumentation/aws-lambda/aws-lambda-events-2.2/library/src/main/java/io/opentelemetry/instrumentation/awslambdaevents/v2_2/internal/ApiGatewayProxyAttributesExtractor.java

Lines 34 to 37 in 4f94664

	// copied from FaasIncubatingAttributes
	private static final AttributeKey<String> FAAS_TRIGGER = AttributeKey.stringKey("faas.trigger");
	// copied from FaasIncubatingAttributes.FaasTriggerValues
	private static final String HTTP = "http";

[akats7]

In this case being the spec?

[laurit]

here it would be // copied from DbIncubatingAttributes