Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required status check #1545

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fix required status check #1545

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb15170
Fix required status check
trask Nov 16, 2024
245e7aa
Merge remote-tracking branch 'upstream/main' into fix-required-status…
trask Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
GPG_PASSWORD: ${{ secrets.GPG_PASSWORD }}

required-status-check:
if: github.event_name == 'pull_request'
if: github.event_name == 'pull_request' && always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not following how this helps. Isn't && always() basically && true which is always true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one would think...

check out https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#always

and you can see the difference below, required-status-check is run and fails (and so should block merging even after someone approves this PR), whereas in #1542 for example, required-status-check is skipped (and therefore didn't block merging)

needs:
- build
- integration-test
Expand Down
Loading