Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrent comments for the metric data storage location #5999

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Corrent comments for the metric data storage location #5999

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4bdfa3d
Corrent comments for the metric data storage location
yumosx Nov 23, 2024
02b4bfd
update changelog
yumosx Nov 23, 2024
0e788e2
Removed unnecessary word
yumosx Nov 24, 2024
82e10a4
Merge branch 'main' into yumosx-work
yumosx Nov 24, 2024
93353db
updated the CHANGELOG
yumosx Nov 25, 2024
8864a9f
Update CHANGELOG.md
pellared Nov 25, 2024
567a8f6
Update CHANGELOG.md
pellared Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Fix inconsistent request body closing in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#5954)
- Fix inconsistent request body closing in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#5954)
- Fix invalid exemplar keys in `go.opentelemetry.io/otel/exporters/prometheus`. (#5995)
- Correct comment for `Reader.Collect` in `go.opentelemetry.io/otel/sdk/metric`. (#5999)

<!-- Released section -->
<!-- Don't change this section unless doing release -->
Expand Down
4 changes: 2 additions & 2 deletions sdk/metric/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ type Reader interface {
aggregation(InstrumentKind) Aggregation // nolint:revive // import-shadow for method scoped by type.

// Collect gathers and returns all metric data related to the Reader from
// the SDK and stores it in out. An error is returned if this is called
// after Shutdown or if out is nil.
// the SDK and stores it in rm. An error is returned if this is called
// after Shutdown or if rm is nil.
//
// This method needs to be concurrent safe, and the cancellation of the
// passed context is expected to be honored.
Expand Down
Loading