config: add support for Insecure #6658
Open
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6658 +/- ##
=======================================
- Coverage 73.0% 73.0% -0.1%
=======================================
Files 189 189
Lines 15773 15773
=======================================
- Hits 11525 11519 -6
- Misses 3916 3920 +4
- Partials 332 334 +2
|
dmathieu
reviewed
Jan 22, 2025
| @@ -183,7 +183,7 @@ func otlpGRPCLogExporter(ctx context.Context, otlpConfig *OTLP) (sdklog.Exporter | |||
| } else { | |||
| opts = append(opts, otlploggrpc.WithEndpoint(*otlpConfig.Endpoint)) | |||
| } | |||
| if u.Scheme == "http" { | |||
| if u.Scheme == "http" || (u.Scheme != "https" && otlpConfig.Insecure != nil && *otlpConfig.Insecure) { | |||
There was a problem hiding this comment.
I would like to and spent some time on it already, but these options get double wrapped in structs with only private members so I was at a loss as to how to inspect the output of this method. Happy to take suggestions
There was a problem hiding this comment.
@dmathieu did you have any suggestions here?
|
@codeboten, PTAL as a codeowner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6351
Based on spec here: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options (search "Insecure")