Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otelhttp): generate New Server Metrics in otelhttp #6411

Merged
merged 25 commits into from
Dec 16, 2024

Conversation

flc1125
Copy link
Member

@flc1125 flc1125 commented Dec 9, 2024

closed #6262

@flc1125 flc1125 requested review from dmathieu and a team as code owners December 9, 2024 14:37
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.5%. Comparing base (a3180db) to head (220d4a8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6411     +/-   ##
=======================================
+ Coverage   68.3%   68.5%   +0.1%     
=======================================
  Files        200     200             
  Lines      16682   16768     +86     
=======================================
+ Hits       11404   11490     +86     
  Misses      4933    4933             
  Partials     345     345             
Files with missing lines Coverage Δ
...entation/net/http/otelhttp/internal/semconv/env.go 92.1% <100.0%> (+1.1%) ⬆️
...ion/net/http/otelhttp/internal/semconv/httpconv.go 86.9% <100.0%> (+3.6%) ⬆️
...ntation/net/http/otelhttp/internal/semconv/util.go 89.4% <100.0%> (+1.4%) ⬆️
...tion/net/http/otelhttp/internal/semconv/v1.20.0.go 93.6% <100.0%> (-0.3%) ⬇️

@flc1125
Copy link
Member Author

flc1125 commented Dec 9, 2024

Additionally, I would like to ask if there is a test package similar to tracetest for metric? I checked the code and did not find anything similar.

@dmathieu
Copy link
Member

There is metricdatatest. I am changing the test struct used in this PR to use that in #6400

@flc1125
Copy link
Member Author

flc1125 commented Dec 10, 2024

There is metricdatatest. I am changing the test struct used in this PR to use that in #6400

No problem. i can wait for it to merge.

@MrAlias
Copy link
Contributor

MrAlias commented Dec 10, 2024

There is metricdatatest. I am changing the test struct used in this PR to use that in #6400

No problem. i can wait for it to merge.

Merged.

@flc1125
Copy link
Member Author

flc1125 commented Dec 11, 2024

Recently quite busy, doing various year-end summaries and planning. The progress will be a bit slow, please understand.

# Conflicts:
#	CHANGELOG.md
#	instrumentation/net/http/otelhttp/internal/semconv/env.go
#	instrumentation/net/http/otelhttp/internal/semconv/env_test.go
#	instrumentation/net/http/otelhttp/internal/semconv/httpconv.go
#	instrumentation/net/http/otelhttp/internal/semconv/httpconv_test.go
#	instrumentation/net/http/otelhttp/internal/semconv/v1.20.0_test.go
@flc1125 flc1125 marked this pull request as draft December 11, 2024 05:25
@flc1125 flc1125 marked this pull request as ready for review December 13, 2024 08:27
@flc1125
Copy link
Member Author

flc1125 commented Dec 13, 2024

Already prepared for review.

If the unit test coverage requirement is very strict, I can supplement it later.

Co-authored-by: Damien Mathieu <[email protected]>
@dmathieu dmathieu merged commit ce79eff into open-telemetry:main Dec 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Generate New Server Metrics in otelhttp
4 participants