-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otelhttp): generate New Server Metrics in otelhttp
#6411
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6411 +/- ##
=======================================
+ Coverage 68.3% 68.5% +0.1%
=======================================
Files 200 200
Lines 16682 16768 +86
=======================================
+ Hits 11404 11490 +86
Misses 4933 4933
Partials 345 345
|
Additionally, I would like to ask if there is a test package similar to tracetest for metric? I checked the code and did not find anything similar. |
There is metricdatatest. I am changing the test struct used in this PR to use that in #6400 |
No problem. i can wait for it to merge. |
Merged. |
Recently quite busy, doing various year-end summaries and planning. The progress will be a bit slow, please understand. |
# Conflicts: # CHANGELOG.md # instrumentation/net/http/otelhttp/internal/semconv/env.go # instrumentation/net/http/otelhttp/internal/semconv/env_test.go # instrumentation/net/http/otelhttp/internal/semconv/httpconv.go # instrumentation/net/http/otelhttp/internal/semconv/httpconv_test.go # instrumentation/net/http/otelhttp/internal/semconv/v1.20.0_test.go
Already prepared for review.
|
Co-authored-by: Damien Mathieu <[email protected]>
closed #6262