-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method and benchmarks for pooling metric options #6394
Conversation
93a6e56
to
24be4a7
Compare
22d5b93
to
57fc034
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6394 +/- ##
=====================================
Coverage 67.8% 67.8%
=====================================
Files 200 200
Lines 16635 16641 +6
=====================================
+ Hits 11291 11297 +6
Misses 4999 4999
Partials 345 345
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is starting to look good :)
We will need a changelog entry though.
Co-authored-by: Damien Mathieu <[email protected]>
e246950
to
6991013
Compare
Co-authored-by: Damien Mathieu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Can you please update the branch?
…trib into pool-metric-options # Conflicts: # CHANGELOG.md # instrumentation/net/http/otelhttp/internal/semconv/env_test.go
f61792a
to
06c5578
Compare
PR updated to resolve conflicts |
Revert invalid spelling change.
This PR improves the
RecordMetrics()
allocations using a pool for themetric.AddOption
slice.benchstat main.txt pool.txt
:Fixes #5968