-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add support for extra TLS configuration #6378
base: main
Are you sure you want to change the base?
Conversation
721db8a
to
9e39964
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6378 +/- ##
=======================================
- Coverage 68.5% 68.5% -0.1%
=======================================
Files 200 200
Lines 16781 16791 +10
=======================================
+ Hits 11503 11509 +6
- Misses 4933 4936 +3
- Partials 345 346 +1
|
9e39964
to
640733b
Compare
640733b
to
bb466fe
Compare
@dmathieu would you be able to re-approve this? I updated it against main |
@dmathieu would appreciate another approval - I think last time you might have forgotten to hit the button, because I didn't see a new approval after you thumbsup'd my comment |
I'm approving the CI. But you don't need another PR approval from me. We do need an approval from another approver though. |
@dmathieu ooh, I see. I also finally discovered the issue with the CHANGELOG validation so that should stop failing now. |
Co-authored-by: Damien Mathieu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattsains!
It looks like the error messages are different on windows versus linux, do you have any suggestions on how to update the tests? Should I be doing something like:
? |
Added support for configuring:
ClientCertificate
ClientKey
Based on #6376
Partially addresses #6351