Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add support for extra TLS configuration #6378

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mattsains
Copy link

@mattsains mattsains commented Nov 27, 2024

Added support for configuring:

  • ClientCertificate
  • ClientKey

Based on #6376
Partially addresses #6351

@mattsains mattsains requested review from pellared and a team as code owners November 27, 2024 22:07
@github-actions github-actions bot requested a review from codeboten November 27, 2024 22:07
@mattsains mattsains force-pushed the client-config branch 2 times, most recently from 721db8a to 9e39964 Compare December 2, 2024 19:08
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.5%. Comparing base (958c959) to head (58ab334).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
config/v0.3.0/config.go 81.8% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6378     +/-   ##
=======================================
- Coverage   68.5%   68.5%   -0.1%     
=======================================
  Files        200     200             
  Lines      16781   16791     +10     
=======================================
+ Hits       11503   11509      +6     
- Misses      4933    4936      +3     
- Partials     345     346      +1     
Files with missing lines Coverage Δ
config/v0.3.0/log.go 95.3% <100.0%> (ø)
config/v0.3.0/metric.go 85.8% <100.0%> (ø)
config/v0.3.0/trace.go 97.3% <100.0%> (ø)
config/v0.3.0/config.go 85.0% <81.8%> (+0.6%) ⬆️

... and 1 file with indirect coverage changes

.golangci.yml Outdated Show resolved Hide resolved
@dmathieu dmathieu marked this pull request as draft December 13, 2024 09:02
mattsains added a commit to mattsains/opentelemetry-go-contrib that referenced this pull request Jan 3, 2025
mattsains added a commit to mattsains/opentelemetry-go-contrib that referenced this pull request Jan 3, 2025
mattsains added a commit to mattsains/opentelemetry-go-contrib that referenced this pull request Jan 3, 2025
@mattsains mattsains marked this pull request as ready for review January 3, 2025 20:18
@mattsains mattsains changed the title config: add support for extra configuration config: add support for extra TLS configuration Jan 3, 2025
@mattsains
Copy link
Author

@dmathieu would you be able to re-approve this? I updated it against main

@mattsains
Copy link
Author

@dmathieu would appreciate another approval - I think last time you might have forgotten to hit the button, because I didn't see a new approval after you thumbsup'd my comment

@dmathieu
Copy link
Member

dmathieu commented Jan 9, 2025

I'm approving the CI. But you don't need another PR approval from me. We do need an approval from another approver though.

@mattsains
Copy link
Author

@dmathieu ooh, I see. I also finally discovered the issue with the CHANGELOG validation so that should stop failing now.

CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Damien Mathieu <[email protected]>
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattsains!

@mattsains
Copy link
Author

It looks like the error messages are different on windows versus linux, do you have any suggestions on how to update the tests? Should I be doing something like:

if runtime.GOOS == "windows" {
   wantErr = "error 1"
} else {
   wantErr = "error 2"
}

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants