Temporarily consider 429s as success in links check #6210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
added
the
Skip Changelog
dashpole
reviewed
Oct 8, 2024
dashpole
approved these changes
Oct 9, 2024
XSAM
approved these changes
Oct 9, 2024
hanyuancheung
approved these changes
Oct 10, 2024
MrAlias
approved these changes
Oct 10, 2024
|
The remaining failure is due to the recent lychee action upgrade, not the 429s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This considers 429s as a success, until we can get lychee to cache success requests even if there's a failure.
This should only be a temporary measure. But ignoring one status code seems better than entirely disabling the check.
Related: #6183.