Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add support for temporality configuration #5860

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

codeboten
Copy link
Contributor

This adds functionality to set temporality preferences for exporters in the configuration of metric exporters.

This adds functionality to set temporality preferences for exporters in the configuration of metric exporters.

Signed-off-by: Alex Boten <[email protected]>
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.0%. Comparing base (9393fc0) to head (3e68a72).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
config/metric.go 58.8% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5860     +/-   ##
=======================================
- Coverage   67.0%   67.0%   -0.1%     
=======================================
  Files        194     194             
  Lines      12658   12692     +34     
=======================================
+ Hits        8490    8510     +20     
- Misses      3889    3903     +14     
  Partials     279     279             
Files with missing lines Coverage Δ
config/metric.go 87.7% <58.8%> (-3.8%) ⬇️

@codeboten codeboten marked this pull request as ready for review October 7, 2024 21:41
@codeboten codeboten requested review from pellared and a team as code owners October 7, 2024 21:41
Signed-off-by: Alex Boten <[email protected]>
@dmathieu dmathieu merged commit 355fbbd into open-telemetry:main Oct 9, 2024
11 of 25 checks passed
@codeboten codeboten deleted the codeboten/temporality branch October 9, 2024 13:47
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
MrAlias added a commit that referenced this pull request Oct 14, 2024
### Added

- The `Severitier` and `SeverityVar` types are added to
`go.opentelemetry.io/contrib/processors/minsev` allowing dynamic
configuration of the severity used by the `LogProcessor`. (#6116)
- Move examples from `go.opentelemetry.io/otel` to this repository under
`examples` directory. (#6158)
- Support yaml/json struct tags for generated code in
`go.opentelemetry.io/contrib/config`. (#5433)
- Add support for parsing YAML configuration via `ParseYAML` in
`go.opentelemetry.io/contrib/config`. (#5433)
- Add support for temporality preference configuration in
`go.opentelemetry.io/contrib/config`. (#5860)

### Changed

- The function signature of `NewLogProcessor` in
`go.opentelemetry.io/contrib/processors/minsev` has changed to accept
the added `Severitier` interface instead of a `log.Severity`. (#6116)
- Updated `go.opentelemetry.io/contrib/config` to use the
[v0.3.0](https://github.com/open-telemetry/opentelemetry-configuration/releases/tag/v0.3.0)
release of schema which includes backwards incompatible changes. (#6126)
- `NewSDK` in `go.opentelemetry.io/contrib/config` now returns a no-op
SDK if `disabled` is set to `true`. (#6185)
- The deprecated
`go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho`
package has found a Code Owner. The package is no longer deprecated.
(#6207)

### Fixed

- Possible nil dereference panic in
`go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace`.
(#5965)
- `logrus.Level` transformed to appropriate `log.Severity` in
`go.opentelemetry.io/contrib/bridges/otellogrus`. (#6191)

### Removed

- The `Minimum` field of the `LogProcessor` in
`go.opentelemetry.io/contrib/processors/minsev` is removed.
  Use `NewLogProcessor` to configure this setting. (#6116)
- The deprecated
`go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron`
package is removed. (#6186)
- The deprecated `go.opentelemetry.io/contrib/samplers/aws/xray` package
is removed. (#6187)

---------

Co-authored-by: David Ashpole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants