exporters/autoexport: add support for comma-separated values for OTEL_{METRICS,TRACES,LOGS}_EXPORTER #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5830 +/- ##
=====================================
Coverage 65.6% 65.7%
=====================================
Files 204 206 +2
Lines 12974 13027 +53
=====================================
+ Hits 8522 8565 +43
- Misses 4198 4205 +7
- Partials 254 257 +3
|
dmathieu
reviewed
Jul 1, 2024
|
This is a rather large PR which, at a first glance, seems not to include only what's described in the PR title. Could it be split into smaller PRs? |
…OTEL_*_EXPORTER (open-telemetry#4471) This commit introduces the support of comma-separated value for OTEL_{METRICS,TRACES,LOGS}_EXPORTER. New functions can now be used to intialize a list of exporters: NewMetricReaders, NewLogExporters, NewSpanExporters. Old ones (NewMetricReader, NewLogExporter, NewSpanExporter) are now deprecated but still continue to do they initial work to avoid breaking change. Signed-off-by: thomasgouveia <[email protected]>
Signed-off-by: thomasgouveia <[email protected]>
thomasgouveia
force-pushed
the
f-rework-autoexport
branch
from
5eed2fe to
2886f35
Compare
Signed-off-by: thomasgouveia <[email protected]>
Signed-off-by: thomasgouveia <[email protected]>
Signed-off-by: thomasgouveia <[email protected]>
Signed-off-by: thomasgouveia <[email protected]>
…rib into f-rework-autoexport
Signed-off-by: thomasgouveia <[email protected]>
|
Hi @dmathieu, I've updated the PR to remove code changes unrelated to the feature. Let me know if I missed something! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the support of comma-separated values for the following environment variables:
OTEL_TRACES_EXPORTEROTEL_LOGS_EXPORTEROTEL_METRICS_EXPORTERThe functions
NewLogExporter,NewMetricReader, andNewSpanExporterare now deprecated but will continue to work to ensure backward compatibility. Users must consider moving toNewLogExporters,NewMetricReaders, andNewSpanExportersto initialize one or more exporters. (See example_test.go).Unit tests were adapted to use the newly created functions. A test has been added for each signal to ensure the respective deprecated function continues working.
Blocked by #5816 (will need to be rebased once merged)Closes #4471