Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Semconv migration Part1 Server Metrics - v1.20.0 support #5818

Merged

fix missing nil

3f304d0
Select commit
Loading
Failed to load commit list.
Merged

HTTP Semconv migration Part1 Server Metrics - v1.20.0 support #5818

fix missing nil
3f304d0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 1, 2024 in 0s

65.5% (+0.0%) compared to 7ee1471

View this Pull Request on Codecov

65.5% (+0.0%) compared to 7ee1471

Details

Codecov Report

Attention: Patch coverage is 90.19608% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.5%. Comparing base (7ee1471) to head (3f304d0).

Files Patch % Lines
...tion/net/http/otelhttp/internal/semconv/v1.20.0.go 88.2% 5 Missing and 3 partials ⚠️
...ntation/net/http/otelhttp/internal/semconv/util.go 33.3% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5818   +/-   ##
=====================================
  Coverage   65.5%   65.5%           
=====================================
  Files        203     203           
  Lines      12881   12945   +64     
=====================================
+ Hits        8438    8491   +53     
- Misses      4194    4200    +6     
- Partials     249     254    +5     
Files Coverage Δ
instrumentation/net/http/otelhttp/common.go 100.0% <ø> (ø)
instrumentation/net/http/otelhttp/handler.go 90.5% <100.0%> (-1.4%) ⬇️
...entation/net/http/otelhttp/internal/semconv/env.go 88.6% <100.0%> (+3.6%) ⬆️
...ntation/net/http/otelhttp/internal/semconv/util.go 89.7% <33.3%> (-2.0%) ⬇️
...tion/net/http/otelhttp/internal/semconv/v1.20.0.go 91.2% <88.2%> (-8.8%) ⬇️

... and 1 file with indirect coverage changes