Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xray client: return an error if the HTTP request failed #5718

Merged
merged 15 commits into from
Sep 25, 2024

Merge branch 'main' into bug-5717-obtain-xray-sampling-rules-silent-fail

4aff441
Select commit
Loading
Failed to load commit list.
Merged

xray client: return an error if the HTTP request failed #5718

Merge branch 'main' into bug-5717-obtain-xray-sampling-rules-silent-fail
4aff441
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jul 1, 2024 in 0s

88.8% of diff hit (target 64.5%)

View this Pull Request on Codecov

88.8% of diff hit (target 64.5%)

Annotations

Check warning on line 133 in samplers/aws/xray/internal/client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

samplers/aws/xray/internal/client.go#L133 

Added line #L133 was not covered by tests
View more details on Codecov