Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Aneurysm9 to emeritus status #5533

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

Aneurysm9
Copy link
Member

I have been unable to provide this position the bandwidth that it deserves and it is time to formalize recognition of that fact.

Signed-off-by: Anthony J Mirabella <[email protected]>
@Aneurysm9 Aneurysm9 requested a review from a team May 8, 2024 15:23
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we open issues to track the components that are now missing CODEOWNERS? Or do we know of anyone who would be a good fit?

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fist of all, thanks for your contributions to the project 🙏

If it is not you then are you able to find someone in AWS who could be a codeowner of AWS detectors and instrumentations?

@XSAM XSAM added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 8, 2024
@Aneurysm9
Copy link
Member Author

I have some people internally I'm going to reach out to about taking the code owner role for the AWS components in this repo, but don't have any names to give at this time. If you'd like me to keep my name on them in the interim I can do so, but will be responsive on a best-effort basis.

@pellared
Copy link
Member

pellared commented May 8, 2024

If you'd like me to keep my name on them in the interim I can do so, but will be responsive on a best-effort basis.

I think it will be a lot better than having nobody.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.7%. Comparing base (413e164) to head (2bf7239).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5533     +/-   ##
=======================================
- Coverage   62.7%   62.7%   -0.1%     
=======================================
  Files        192     192             
  Lines      11786   11786             
=======================================
- Hits        7401    7399      -2     
- Misses      4169    4170      +1     
- Partials     216     217      +1     

see 1 file with indirect coverage changes

@pellared pellared merged commit 5d8c6d2 into open-telemetry:main May 9, 2024
23 checks passed
@Aneurysm9 Aneurysm9 deleted the emeritus branch May 9, 2024 18:16
zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this pull request May 20, 2024
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants