-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module github.com/aws/aws-sdk-go-v2/service/dynamodb to v1.32.0 #5517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fixed (a test fails after the bump).
CC @Aneurysm9
ce767e9
to
5cb1ef5
Compare
9c36d94
to
98d1657
Compare
Fix by @Aneurysm9: --- a/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes_test.go
+++ b/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes_test.go
@@ -122,7 +122,7 @@ func TestDynamodbTagsCreateTableInput(t *testing.T) {
assert.Contains(t, attributes, attribute.StringSlice(
"aws.dynamodb.global_secondary_indexes",
[]string{
- `{"IndexName":"index1","KeySchema":[{"AttributeName":"attributename","KeyType":"HASH"}],"Projection":{"NonKeyAttributes":["non-key-attributes"],"ProjectionType":""},"ProvisionedThroughput":null}`,
+ `{"IndexName":"index1","KeySchema":[{"AttributeName":"attributename","KeyType":"HASH"}],"Projection":{"NonKeyAttributes":["non-key-attributes"],"ProjectionType":""},"OnDemandThroughput":null,"ProvisionedThroughput":null}`,
},
))
assert.Contains(t, attributes, attribute.StringSlice(
@@ -338,7 +338,7 @@ func TestDynamodbTagsUpdateTableInput(t *testing.T) {
assert.Contains(t, attributes, attribute.StringSlice(
"aws.dynamodb.global_secondary_index_updates",
[]string{
- `{"Create":{"IndexName":"index1","KeySchema":[{"AttributeName":"attribute","KeyType":"HASH"}],"Projection":{"NonKeyAttributes":["attribute1","attribute2"],"ProjectionType":"ALL"},"ProvisionedThroughput":null},"Delete":null,"Update":null}`,
+ `{"Create":{"IndexName":"index1","KeySchema":[{"AttributeName":"attribute","KeyType":"HASH"}],"Projection":{"NonKeyAttributes":["attribute1","attribute2"],"ProjectionType":"ALL"},"OnDemandThroughput":null,"ProvisionedThroughput":null},"Delete":null,"Update":null}`,
},
))
assert.Contains(t, attributes, attribute.Float64("aws.dynamodb.provisioned_read_capacity", 123)) I will apply it when other renovate PRs are merged to avoid conflicts. |
7f5fa77
to
14ab2c9
Compare
14ab2c9
to
9f5aff3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5517 +/- ##
=======================================
- Coverage 62.4% 62.4% -0.1%
=======================================
Files 190 190
Lines 11646 11646
=======================================
- Hits 7271 7269 -2
- Misses 4159 4160 +1
- Partials 216 217 +1 |
This PR contains the following updates:
v1.31.1
->v1.32.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.