otelzap: Add skeleton and config options #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
pellared
added
the
Skip Changelog
|
Can you please outline an implementation plan in #5191? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5449 +/- ##
=====================================
Coverage 62.4% 62.4%
=====================================
Files 190 191 +1
Lines 11646 11690 +44
=====================================
+ Hits 7269 7303 +34
- Misses 4160 4170 +10
Partials 217 217
|
pellared
reviewed
May 6, 2024
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
pellared
reviewed
May 7, 2024
pellared
reviewed
May 7, 2024
|
Can you also update the Do you want to be a codeowner as well? Will you be able to maintain otelzap after your internship is finished? |
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
|
yes! will maintain it after internship too |
MrAlias
approved these changes
May 7, 2024
pellared
approved these changes
May 7, 2024
|
@open-telemetry/go-approvers, PTAL. This PR needs a second approval from a non-Splunk employee. |
dashpole
approved these changes
May 8, 2024
zailic
pushed a commit
to zailic/opentelemetry-go-contrib
that referenced
this pull request
May 20, 2024
* Add catalog-info.yaml config file * delete config.yaml * Skeleton of Zapcore and config options * Update bridges/otelzap/config.go Co-authored-by: Robert Pająk <[email protected]> * Update bridges/otelzap/config.go Co-authored-by: Robert Pająk <[email protected]> * Update bridges/otelzap/core.go Co-authored-by: Robert Pająk <[email protected]> * Update bridges/otelzap/config.go Co-authored-by: Robert Pająk <[email protected]> * follow up commit * Update versions.yaml * Update bridges/otelzap/core_test.go Co-authored-by: Robert Pająk <[email protected]> * Update bridges/otelzap/core_test.go Co-authored-by: Robert Pająk <[email protected]> * Update bridges/otelzap/core_test.go Co-authored-by: Robert Pająk <[email protected]> * Update bridges/otelzap/core_test.go Co-authored-by: Robert Pająk <[email protected]> * Update bridges/otelzap/core_test.go Co-authored-by: Robert Pająk <[email protected]> * applied suggestions --------- Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5191
Pre-work #5279