otelslog: Handle nil attribute value properly

open-telemetry · Oct 14, 2024 · 7947e54 · 7947e54
1 parent d6305c0
commit 7947e54
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/bridges/otelslog/handler.go b/bridges/otelslog/handler.go
@@ -411,6 +411,9 @@ func (b *kvBuffer) AddAttr(attr slog.Attr) bool {
 func convertValue(v slog.Value) log.Value {
 	switch v.Kind() {
 	case slog.KindAny:
+		if v.Any() == nil {
+			return log.Value{}
+		}
 		return log.StringValue(fmt.Sprintf("%+v", v.Any()))
 	case slog.KindBool:
 		return log.BoolValue(v.Bool())

diff --git a/bridges/otelslog/handler_test.go b/bridges/otelslog/handler_test.go
@@ -240,6 +240,7 @@ func TestSLogHandler(t *testing.T) {
 					"string", "str",
 					"time", now,
 					"uint64", uint64(3),
+					"nil", nil,
 					// KindGroup and KindLogValuer are left for slogtest.TestHandler.
 				)
 			},
@@ -254,6 +255,7 @@ func TestSLogHandler(t *testing.T) {
 				hasAttr("string", "str"),
 				hasAttr("time", now.UnixNano()),
 				hasAttr("uint64", int64(3)),
+				hasAttr("nil", nil),
 			}},
 		},
 		{