Skip to content

Commit

Permalink
Update option.go
Browse files Browse the repository at this point in the history
Signed-off-by: rehanpfmr <[email protected]>
  • Loading branch information
rehanpfmr authored Jul 30, 2024
1 parent 3766c00 commit 54aedbe
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions instrumentation/github.com/gin-gonic/gin/otelgin/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func WithTracerProvider(provider oteltrace.TracerProvider) Option {

// WithFilter adds a filter to the list of filters used by the handler.
// If any filter indicates to exclude a request then the request will not be
// traced. All filters must allow a request to be traced for a Span to be created.
// traced. All gin and net/http filters must allow a request to be traced for a Span to be created.
// If no filters are provided then all requests are traced.
// Filters will be invoked for each processed request, it is advised to make them
// simple and fast.
Expand All @@ -78,11 +78,6 @@ func WithFilter(f ...Filter) Option {
}

// WithGinFilter adds a gin filter to the list of filters used by the handler.
// If any filter indicates to exclude a request then the request will not be
// traced. All gin and net/http filters must allow a request to be traced for a Span to be created.
// If no filters are provided then all requests are traced.
// Filters will be invoked for each processed request, it is advised to make them
// simple and fast.
func WithGinFilter(f ...GinFilter) Option {
return optionFunc(func(c *config) {
c.GinFilters = append(c.GinFilters, f...)
Expand Down

0 comments on commit 54aedbe

Please sign in to comment.