Skip to content

Commit

Permalink
chore: removing unnecessary comments (#6184)
Browse files Browse the repository at this point in the history
The comment at the top is no longer true, the one at the bottom is no
longer applicable as it was decided to wait to support JSON format
parsing.

Signed-off-by: Alex Boten <[email protected]>
  • Loading branch information
codeboten authored Oct 3, 2024
1 parent 722a536 commit 1c6d9f9
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ func (s *SDK) Shutdown(ctx context.Context) error {
}

// NewSDK creates SDK providers based on the configuration model.
//
// Caution: The implementation only returns noop providers.
func NewSDK(opts ...ConfigurationOption) (SDK, error) {
o := configOptions{}
for _, opt := range opts {
Expand Down Expand Up @@ -129,9 +127,6 @@ func WithOpenTelemetryConfiguration(cfg OpenTelemetryConfiguration) Configuratio
})
}

// TODO: implement parsing functionality:
// - https://github.com/open-telemetry/opentelemetry-go-contrib/issues/4412

// ParseYAML parses a YAML configuration file into an OpenTelemetryConfiguration.
func ParseYAML(file []byte) (*OpenTelemetryConfiguration, error) {
var cfg OpenTelemetryConfiguration
Expand Down

0 comments on commit 1c6d9f9

Please sign in to comment.