Telemetry-based Absinthe instrumentation #88
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instrumentation for
Absinthe
, the GraphQL Elixir-framwork. Relies on some new telemetry work on Absinthe:phases, following the approach of JavaScript libraries
Span names and attributes also follow the JavaScript impl, the closes to a future Semantic Attribute spec.
The "span tracker" used here is to connect traces in a shape that resembles the query shape instead of execution shape. One example is:
In case
name
is an async resolver (for example), the execution will resembles a recursive function, and such our trace will be:With the span tracker, the above trace will become:
That helps visually scan the traces, and it's friendly to folks who doesn't know much about Absinthe internals.