fix: setting oban attributes

[yordis]

• Should I prefix everything with "oban.*" for these attributes?

[yordis]

Should I prefix everything with "oban.*" for these attributes thou? I prefer to do

[bryannaegele]

Should I prefix everything with "oban.*" for these attributes thou? I prefer to do

You can add that to this. Might as well get it done since we're touching it.

[yordis]

@bryannaegele done!

[yordis]

@tsloughter @bryannaegele is there anything I need to do to get this to the finish line?

[bryannaegele]

Looking through this again and I missed a couple of things.

1. We want to move everything to the oban namespace which includes the attributes currently under messaging.oban.* to just oban.*
2. We should have all the attributes namespaced to their function, e.g. job attributes under oban.job.* and these new plugin ones under oban.plugins.plugin_name.* so context is provided and there's no risk of collisions between plugins.

[yordis]

@bryannaegele done, hopefully I understood the assignment

[yordis]

@joaothallis anything else?

I am wondering how to get this to the finish line

[joaothallis]

Should I prefix everything with "oban.*" for these attributes?

Reading the spec it is not specifying that other attributes should start with messasing. But the attributes that are in the spec they can not have the prefix oban.

[yordis]

Added Unit Tests, let me know!

[yordis]

@bryannaegele ready to go

[bryannaegele]

You're going to kill me but would you mind poking at this test that started failing with newer Oban after I bumped it? I think the test just needs to be updated but I'm not an Oban expert

#287

[yordis]

@bryannaegele oban-bg/oban#1035 it needs to be fixed in the Oban side, it was removed by mistake

[bryannaegele]

Awesome! Thanks for following up.