Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Switch to component label for tagging issues #5612

Merged
merged 4 commits into from
May 14, 2024

Conversation

reyang
Copy link
Member

@reyang reyang commented May 13, 2024

Instead of using the unclear "area", switch to component name (NuGet package name).
Apply the component labels to feature request as optional.

@reyang reyang requested a review from a team May 13, 2024 23:47
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (6250307) to head (517f5d9).
Report is 222 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5612      +/-   ##
==========================================
+ Coverage   83.38%   85.71%   +2.32%     
==========================================
  Files         297      254      -43     
  Lines       12531    10982    -1549     
==========================================
- Hits        10449     9413    -1036     
+ Misses       2082     1569     -513     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.40% <ø> (?)
unittests-Solution-Stable 85.70% <ø> (?)
unittests-Unstable-Core 19.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 113 files with indirect coverage changes

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label May 14, 2024
@CodeBlanch CodeBlanch changed the title Switch to component label [repo] Switch to component label for tagging issues May 14, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit a578ed3 into open-telemetry:main May 14, 2024
43 checks passed
@reyang reyang deleted the reyang/component-labels branch May 14, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants