-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure GrpcChannel #5555
Configure GrpcChannel #5555
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akruglikov - Could you please explain why is this needed?
@vishweshbankwar This is necessary to use GrpcWeb, |
This PR doesn't seem to be heading towards the right direction. Check the spec here https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options and search for OTEL_EXPORTER_OTLP_CERTIFICATE. If there are additional feature request that is not covered by the spec, create a spec issue https://github.com/open-telemetry/opentelemetry-specification/issues/new/choose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be related to #4731. |
Maybe. But, at the moment I don't see possibility to set certificate for otlp, I can't switch to 'http/json', can't use other opportunities that are provided by GrpcChannelOptions. And another approach which implemented here 4731 also not finished. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Fixes #
Were added the ability to configure GrpcChannel.
Changes
Were added the ability to configure GrpcChannel.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes