Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure GrpcChannel #5555

Conversation

akruglikov
Copy link

Fixes #
Were added the ability to configure GrpcChannel.

Changes

Were added the ability to configure GrpcChannel.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@akruglikov akruglikov requested a review from a team April 19, 2024 09:42
Copy link

linux-foundation-easycla bot commented Apr 19, 2024

CLA Not Signed

  • ❌ login: @shar-ru / The commit (fcfc390). This user is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click "Corporate", select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.

Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akruglikov - Could you please explain why is this needed?

@akruglikov
Copy link
Author

akruglikov commented Apr 19, 2024

@vishweshbankwar This is necessary to use GrpcWeb,
and also allows us to set up ssl-certificates between the server and clients.

@reyang
Copy link
Member

reyang commented Apr 19, 2024

@vishweshbankwar This is necessary to use GrpcWeb, and also allows us to set up ssl-certificates between the server and clients.

This PR doesn't seem to be heading towards the right direction.

Check the spec here https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options and search for OTEL_EXPORTER_OTLP_CERTIFICATE. If there are additional feature request that is not covered by the spec, create a spec issue https://github.com/open-telemetry/opentelemetry-specification/issues/new/choose.

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reyang
Copy link
Member

reyang commented Apr 19, 2024

Might be related to #4731.

@akruglikov
Copy link
Author

@vishweshbankwar This is necessary to use GrpcWeb, and also allows us to set up ssl-certificates between the server and clients.

This PR doesn't seem to be heading towards the right direction.

Check the spec here https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options and search for OTEL_EXPORTER_OTLP_CERTIFICATE. If there are additional feature request that is not covered by the spec, create a spec issue https://github.com/open-telemetry/opentelemetry-specification/issues/new/choose.

Maybe.

But, at the moment I don't see possibility to set certificate for otlp, I can't switch to 'http/json', can't use other opportunities that are provided by GrpcChannelOptions.

And another approach which implemented here 4731 also not finished.

Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Apr 28, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants