Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.AWS] Execute tests against .NET9 #2328

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 15, 2024

Fixes #2323
Design discussion issue #

Changes

[Resources.AWS] Execute tests against .NET9
Drops unused SupportedNetTargetsWithoutNet9

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters comp:resources.aws Things related to OpenTelemetry.Resources.AWS labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.80%. Comparing base (71655ce) to head (31ab7c3).
Report is 602 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
- Coverage   73.91%   72.80%   -1.11%     
==========================================
  Files         267      371     +104     
  Lines        9615    14251    +4636     
==========================================
+ Hits         7107    10376    +3269     
- Misses       2508     3875    +1367     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 77.13% <ø> (?)
unittests-Exporter.Geneva 59.15% <ø> (?)
unittests-Exporter.InfluxDB 95.14% <ø> (?)
unittests-Exporter.Instana 74.86% <ø> (?)
unittests-Exporter.OneCollector 94.51% <ø> (?)
unittests-Exporter.Stackdriver 79.26% <ø> (?)
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 86.16% <ø> (?)
unittests-Instrumentation.AspNet 77.00% <ø> (?)
unittests-Instrumentation.AspNetCore 70.33% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.37% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 80.12% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcCore 91.42% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 74.11% <ø> (?)
unittests-Instrumentation.Owin 88.12% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.76% <ø> (?)
unittests-Instrumentation.Runtime 98.02% <ø> (?)
unittests-Instrumentation.SqlClient 89.54% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.21% <ø> (?)
unittests-Instrumentation.Wcf 78.57% <ø> (?)
unittests-PersistentStorage 65.88% <ø> (?)
unittests-Resources.AWS 77.43% <ø> (?)
unittests-Resources.Azure 84.56% <ø> (?)
unittests-Resources.Container 67.34% <ø> (?)
unittests-Resources.Gcp 71.15% <ø> (?)
unittests-Resources.Host 73.91% <ø> (?)
unittests-Resources.OperatingSystem 76.98% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 78.26% <ø> (?)
unittests-Sampler.AWS 86.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 379 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review November 15, 2024 13:59
@Kielek Kielek requested a review from a team as a code owner November 15, 2024 13:59
@Kielek
Copy link
Contributor Author

Kielek commented Nov 15, 2024

@xiang17, FYI

@Kielek Kielek merged commit d5b47cb into open-telemetry:main Nov 18, 2024
208 of 209 checks passed
@Kielek Kielek deleted the resources.aws-net9-tests branch November 18, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.aws Things related to OpenTelemetry.Resources.AWS infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources.AWS - support .NET9
4 participants