Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SqlClient] For CommandType.StoredProcedure set db.operation.name and db.collection.name #2279

Merged

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Oct 31, 2024

Towards #2222

db.operation.name and db.collection.name are required attributes when readily available. For stored procedures, they are readily available.

There is some unsettled conversation about whether the attribute name db.collection.name makes sense in the context of stored procedure, so the attribute name may change. For now let's just use db.collection.name.

In a follow on PR, I plan to propose removing the SetDbStatementForStoredProcedure option.

@alanwest alanwest requested a review from a team as a code owner October 31, 2024 01:04
@github-actions github-actions bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (71655ce) to head (a572258).
Report is 568 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2279       +/-   ##
===========================================
+ Coverage   73.91%   90.96%   +17.05%     
===========================================
  Files         267        8      -259     
  Lines        9615      310     -9305     
===========================================
- Hits         7107      282     -6825     
+ Misses       2508       28     -2480     
Flag Coverage Δ
unittests-Instrumentation.SqlClient 90.96% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ient/Implementation/SqlClientDiagnosticListener.cs 83.95% <100.00%> (ø)

... and 271 files with indirect coverage changes

@alanwest alanwest merged commit d4b2e61 into open-telemetry:main Oct 31, 2024
56 checks passed
@alanwest alanwest deleted the alanwest/sp-collection-operation branch October 31, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants