pr feedback

open-telemetry · Nov 25, 2024 · cecbf1e · cecbf1e
1 parent 894fb19
commit cecbf1e
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs b/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs
@@ -141,14 +141,13 @@ public void OnStartActivity(Activity activity, object? payload)
             {
                 // see the spec https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/http/http-spans.md
                 HttpTagHelper.RequestDataHelper.SetHttpMethodTag(activity, request.Method.Method);
-            }
-
-            if (!IsNet9OrGreater && request.RequestUri != null)
-            {
-                activity.SetTag(SemanticConventions.AttributeServerAddress, request.RequestUri.Host);
-                activity.SetTag(SemanticConventions.AttributeServerPort, request.RequestUri.Port);
 
-                activity.SetTag(SemanticConventions.AttributeUrlFull, HttpTagHelper.GetUriTagValueFromRequestUri(request.RequestUri, this.options.DisableUrlQueryRedaction));
+                if (request.RequestUri != null)
+                {
+                    activity.SetTag(SemanticConventions.AttributeServerAddress, request.RequestUri.Host);
+                    activity.SetTag(SemanticConventions.AttributeServerPort, request.RequestUri.Port);
+                    activity.SetTag(SemanticConventions.AttributeUrlFull, HttpTagHelper.GetUriTagValueFromRequestUri(request.RequestUri, this.options.DisableUrlQueryRedaction));
+                }
             }
 
             try