Remove old push based batcher #12233
Open
+581
−1,817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
Feb 1, 2025
| "go.opentelemetry.io/collector/pipeline" | ||
| ) | ||
|
|
||
| var usePullingBasedExporterQueueBatcher = featuregate.GlobalRegistry().MustRegister( | ||
| "exporter.UsePullingBasedExporterQueueBatcher", | ||
| featuregate.StageBeta, |
There was a problem hiding this comment.
In the previous release was alpha, turned to beta in this release. Decided to remove this sooner, since we want to complete the exportehelper this cycle.
bogdandrutu
force-pushed
the
rm-old-push-based-batcher
branch
2 times, most recently
from
ba805c4 to
f048ea8
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
rm-old-push-based-batcher
branch
from
f048ea8 to
047b8ea
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (83.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12233 +/- ##
==========================================
- Coverage 91.30% 91.11% -0.19%
==========================================
Files 464 463 -1
Lines 25662 25489 -173
==========================================
- Hits 23430 23224 -206
- Misses 1819 1854 +35
+ Partials 413 411 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/open-telemetry/opentelemetry-collector/tree/main/featuregate#feature-lifecycle