-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add githubgen tool to enhance issue templates #11756
base: main
Are you sure you want to change the base?
[chore] add githubgen tool to enhance issue templates #11756
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11756 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 446 446
Lines 23742 23742
=======================================
Hits 21712 21712
Misses 1654 1654
Partials 376 376 ☔ View full report in Codecov by Sentry. |
eeb45e6
to
e969405
Compare
@@ -15,7 +15,7 @@ status: | |||
distributions: [] | |||
unsupported_platforms: [freebsd, illumos] | |||
codeowners: | |||
active: [some] | |||
active: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed since some
is an actual user and not affiliated or related to OTel
.github/CODEOWNERS
Outdated
# | ||
|
||
* @open-telemetry/collector-approvers | ||
|
||
# List all maintainers individually so all of them are notified | ||
.github/CODEOWNERS @codeboten @BogdanDrutu @dmitryax @mx-psi | ||
docs/rfc @codeboten @BogdanDrutu @dmitryax @mx-psi | ||
|
||
cmd/githubgen/ @open-telemetry/collector-approvers @atoulme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hope this fine since @atoulme is also maintainer for the tool in contrib :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to put your name here too.
@@ -0,0 +1,10 @@ | |||
type: rfcs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added this for completeness sake and to make githubgen work correctly. owners list taken from current codeowners file
https://github.com/open-telemetry/opentelemetry-go-build-tools/ is probably the right place. Could we just pull the module from contrib (like we do with chloggen) and if we move it update the reference? Referencing it in the |
@evan-bradley that would be possible but I made a few minor changes to the tool to make it work with this repo (e.g. changing the file templates), so that would need to be parameterized in the original tool first to be able to do that. I wanted to do exactly that in a follow up issue afterwards to be able to clearly see what we need to change in the tool to make it general enough to serve both or even more repos in the future. |
I filed open-telemetry/opentelemetry-collector-contrib#36691 to take care of moving githubgen to the build-tools repo |
yes, go-build-tools seems like a better home. |
@mowies Do you think moving to go-build-tools as a first step is doable? I think it's probably less of a hassle than copying the code here |
I'm already working on it :) |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
this is still active |
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
3b7fa2d
to
ef99e30
Compare
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Looking good to me, how about getting it out of draft and fixing conflicts, and then we can get it in? |
yes! but ideally, i'd like to merge and maybe also release open-telemetry/opentelemetry-go-build-tools#655 first |
# Conflicts: # internal/tools/go.mod # internal/tools/go.sum
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
This PR enhances some of the existing issue templates by changing them to be interactive forms, similar to collector-contrib. This is needed to be able to automate codeowner updates and to then be able to ping codeowners reliably with automated tooling.
Follow ups:
Part of #11562