RFC - Pipeline Component Telemetry #11406
Open
+218
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11406 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 443 443
Lines 23770 23770
=======================================
Hits 21776 21776
Misses 1620 1620
Partials 374 374 ☔ View full report in Codecov by Sentry. |
djaglowski
force-pushed
the
component-telemetry-rfc
branch
from
99e3086
to
5df52e1
Compare
djaglowski
added
Skip Changelog
codeboten
reviewed
Oct 10, 2024
bogdandrutu
reviewed
Oct 10, 2024
bogdandrutu
reviewed
Oct 16, 2024
bogdandrutu
reviewed
Oct 16, 2024
djaglowski
changed the title
|
Based on some offline feedback, I've broadened the scope of the RFC, while simultaneously clarifying that it is intended to evolve as we identify additional standards. |
jaronoff97
reviewed
Oct 23, 2024
dmathieu
reviewed
Oct 24, 2024
jaronoff97
reviewed
Oct 24, 2024
mx-psi
approved these changes
Oct 29, 2024
wildum
reviewed
Oct 30, 2024
wildum
reviewed
Oct 30, 2024
wildum
approved these changes
Oct 30, 2024
jaronoff97
approved these changes
Oct 30, 2024
evan-bradley
approved these changes
Nov 4, 2024
jpkrohling
reviewed
Nov 4, 2024
|
Some of my comments might have been discussed before, in which case, feel free to ignore me and just mark the items as resolved. |
dmitryax
reviewed
Nov 6, 2024
dmitryax
reviewed
Nov 17, 2024
Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Damien Mathieu <[email protected]>
Co-authored-by: William Dumont <[email protected]>
Co-authored-by: Evan Bradley <[email protected]>
djaglowski
force-pushed
the
component-telemetry-rfc
branch
from
7d7a75b
to
a7a15e5
Compare
djaglowski
added
the
rfc:final-comment-period
codeboten
added a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
This sets the level of all metrics that where not previously stabilized as alpha. Since many of these metrics will change as a result of open-telemetry#11406, it made sense to me to set their stability as alpha. Signed-off-by: Alex Boten <[email protected]>
|
This has enough approvals and has entered the 'final comment period'. I will merge this on 2024-11-27 if nobody blocks before. cc @open-telemetry/collector-approvers |
jpkrohling
approved these changes
Nov 22, 2024
codeboten
added a commit
that referenced
this pull request
Nov 22, 2024
This sets the level of all metrics that where not previously stabilized as alpha. Since many of these metrics will change as a result of #11406, it made sense to me to set their stability as alpha. --------- Signed-off-by: Alex Boten <[email protected]>
|
I believe all feedback has been addressed. #11743 represents two followup items raised by @jpkrohling, but I believe the RFC is clear that some changes are anticipated. |
jpkrohling
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a RFC for normalized telemetry across all pipeline components. See #11343
edit by @mx-psi: