Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] fix renovate regex config for good #737

Merged

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 18, 2024

This PR fixes the goreleaser renovate updates for good. I tested the setup on my own fork, and this would be the resulting PR for a goreleaser update.

Fixes #668

This PR adds an off-the-shelf regex preset (customManagers:githubActionsVersions) to update versions in github actions pipelines and a bit of custom regex to extract the correct versions from goreleaser-pro. This is particularly tricky, because the github actions version field need the version without -pro and the go module does need the -pro suffix. So separate version extraction regexes were needed to achieve that.

Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies marked this pull request as ready for review November 18, 2024 15:52
@mowies mowies requested a review from a team as a code owner November 18, 2024 15:52
@mowies mowies requested a review from ChrsMark November 18, 2024 15:52
@mx-psi
Copy link
Member

mx-psi commented Nov 19, 2024

@mowies LGTM, can you merge main on this branch?

@mx-psi
Copy link
Member

mx-psi commented Nov 19, 2024

CI failed 🤔

@mowies
Copy link
Member Author

mowies commented Nov 20, 2024

@mx-psi a rerun did the trick 🤷🏼 i couldn't see any errors in the failing runs either...

@mx-psi
Copy link
Member

mx-psi commented Nov 20, 2024

@mx-psi a rerun did the trick 🤷🏼 i couldn't see any errors in the failing runs either...

Same here, could just be an infra issue on Github Actions side. Merging!

@mx-psi mx-psi merged commit 1eb7603 into open-telemetry:main Nov 20, 2024
48 checks passed
@mowies mowies deleted the fix-renovate-regex-for-good branch November 20, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move back to latest for goreleaser
2 participants