-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for linux/s390x architecture #384
Add support for linux/s390x architecture #384
Conversation
We need this done before on the core and contrib repositories before adding to -releases, so that we are sure the code at least compiles once we are ready to perform a release. |
014ca45
to
77e6966
Compare
IIUC, we wait for the merge until the PRs for core and contrib have been merged, right? Or is there anything else required from my side? |
Looks like EasyCLA is still not happy about this one. |
77e6966
to
56ee8f5
Compare
I have refreshed it, don't know why it expired(?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like goreleaser is failing for s390x, any idea? https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/6157223841/job/16732668333?pr=384#step:7:60
This commit enables platform support for the `linux/s390x` architecture in the CI pipeline. Signed-off-by: Bjoern Walk <[email protected]>
56ee8f5
to
4e88c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing @bwalk-at-ibm, to return to @jpkrohling's comment, is the plan to add this platform to the list of platforms in the contrib repo as well?
That's the idea. Here's the PR open-telemetry/opentelemetry-collector-contrib#25139. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contrib & core PRs have been merged. Thanks @bwalk-at-ibm 👍🏻
Thanks a lot! |
The
s390x
CPU architecture is the base for IBM zSeries (aka mainframe) systems. It is beneficial for users of this platform to have a supported way to install pre-compiled binaries for the OpenTelemetry collector in a Linux environment. This issue and associated pull requests will enable the building of all relevant binary artifacts forlinux/s390x
as part of the regular CI pipeline.IBM has performed tests internally to ensure successful build (via cross-compilation) and runtime (on native platform) integrity of the OpenTelemetry collector (core and contrib) via the unit test suites and specific use-cases.
For more information and discussion please refer to the initial feature request issue (#378).