Added setting to config to redact data of all types #37595
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redaction is done based on its AsString value rather than SDR. This is based on this issue: open-telemetry#36684
Tiberius202
requested review from
dmitryax,
mx-psi,
TylerHelmuth and
a team
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The redaction is done based on its AsString value
rather than SDR. This is based on this issue:
#36684
The bug is that credit card numbers (as in the example on the README) are often provided as int numbers. The current redaction processor ignores all fields that are not of type int.
Link to tracking issue
#36684
Fixes No way to redact non string values
Documentation
I added the setting and turned it to true in the README as redacting un-delimited credit cards would definitely be under the scope of this setting.