fix(servicegraph): make virtual node tests reliable on Windows #37550
+59
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The virtual node tests (TestVirtualNodeServerLabels and TestVirtualNodeClientLabels) were failing intermittently on Windows due to timing issues. This change: - Reduces MetricsFlushInterval and StoreExpirationLoop to 10ms - Adds a timeout-based polling mechanism to wait for metrics generation - Replaces unreliable sleep with proper metric availability checks - Improves error messaging for test failures Fixes open-telemetry#33679
pjanotti
reviewed
Jan 29, 2025
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: bug_fix |
There was a problem hiding this comment.
This change doesn't require a change log: it is not visible to users. You can remove this file from the change I will add the label to skip the check for a change log.
pjanotti
reviewed
Jan 29, 2025
| // Wait for metrics to be generated with timeout | ||
| deadline := time.Now().Add(5 * time.Second) | ||
| var metrics []pmetric.Metrics | ||
| for time.Now().Before(deadline) { |
There was a problem hiding this comment.
Side note: you can keep using the assert.Eventually or assert.EventuallyWithT, the main advantage being the error message in case of failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The virtual node tests (TestVirtualNodeServerLabels and TestVirtualNodeClientLabels) were failing intermittently on Windows due to timing issues. This change:
Link to tracking issue
Fixes #33679
Testing
Updates tests
Documentation